Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc fix: add instruction to installling protoc and yamllint in contributing.md #16906

Merged
merged 1 commit into from
Nov 10, 2023
Merged

doc fix: add instruction to installling protoc and yamllint in contributing.md #16906

merged 1 commit into from
Nov 10, 2023

Conversation

moficodes
Copy link
Member

#16904

fix spelling of word maintainer
add link to install protoc 3.20.3
add link to install yamllint

jmhbnz
jmhbnz reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this @moficodes, a quick suggestion below but otherwise this looks like a good addition 👍🏻

CONTRIBUTING.md Outdated Show resolved Hide resolved
@jmhbnz
Copy link
Member

jmhbnz commented Nov 10, 2023

Thanks @moficodes can you please squash commits so we are ready to merge e.g:

git reset --soft HEAD~2
git commit -s -a -m "doc fix: add instruction for installling protoc and yamllint in contributing.md"
git push --force

@moficodes
Copy link
Member Author

@jmhbnz I though the ci auto squashed commits. Maybe we can add that.

@jmhbnz
Copy link
Member

jmhbnz commented Nov 10, 2023 •
edited
Loading

@jmhbnz I though the ci auto squashed commits. Maybe we can add that.

Afaik the etcd project do not squash commits on merge, preference is to instead maintain the full commit history from original authors.

jmhbnz
jmhbnz approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ahrtr
ahrtr approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@ahrtr ahrtr merged commit 3f17ba4 into etcd-io:main Nov 10, 2023
@moficodes moficodes deleted the docs branch November 10, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moficodes @jmhbnz @ahrtr